Remove obsolete challenge actions #18584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migueldemoura
requested review from
a team,
angelampcosta,
bharatnc,
cmackenzie1,
jherre,
soheiokamoto and
victor-perov
as code owners
rupert648
approved these changes
Dec 5, 2024
Deploying cloudflare-docs with
|
| Latest commit: |
339a3f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://39f5e806.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://mdemoura-remove-obsolete-cha.cloudflare-docs-7ou.pages.dev |
Contributor
|
Hi @migueldemoura |
Contributor
Author
|
Happy to adjust those, but the tl;dr is that they were never useful and just outright misleading as we never log the overwhelming majority of challenge failures to security events. |
Contributor
|
We also have a couple of occurrences in the following page, which we can probably delete if they no longer make sense: |
These actions have either never been used or are obsolete and about to be removed.
migueldemoura
force-pushed
the
mdemoura/remove-obsolete-challenge-actions
branch
from
0920432 to
339a3f8
Compare
Contributor
Author
|
Made a few adjustments, feel free to change them! I also noticed that we don't mention every kind of challenge type when referring to the action names, but I guess that can be fixed in a follow-up. |
pedrosousa
approved these changes
Dec 5, 2024
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These actions have either never been used or are obsolete and about to be removed.