Skip to content

Added notes for cache request hostnames #18634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 22, 2025
Merged

Added notes for cache request hostnames #18634

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8fecb56
Added two notes
ToriLindsay Dec 9, 2024
bc2a26c
Update src/content/docs/workers/runtime-apis/cache.mdx
ToriLindsay Dec 13, 2024
8f74b36
Update src/content/docs/workers/runtime-apis/cache.mdx
ToriLindsay Dec 13, 2024
42cbc17
update with example
ToriLindsay Jan 22, 2025
3d7bdaa
Fixed
ToriLindsay Jan 22, 2025
a2cb294
made into note, simplified code example
ToriLindsay Feb 26, 2025
ebeb2d8
Update src/content/docs/workers/runtime-apis/cache.mdx
ToriLindsay Mar 31, 2025
077b5f7
Changed to recommended approach
ToriLindsay Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/content/docs/workers/runtime-apis/cache.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ The `stale-while-revalidate` and `stale-if-error` directives are not supported w

:::

:::note
Do not use dynamic or invalid hostnames in cache requests. This can cause DNS cache failures and latency.
Copy link
Contributor

@mikenomitch mikenomitch Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be more explicit. We should say that the hostname used in the cache request should match your hostname.

And then instead of "DNS cache failures" I'd say "a DNS lookup" which will significantly increase latency.

Copy link
Contributor

@mikenomitch mikenomitch Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if they use "request.headers.host" that'd be the correct hostname to use in all cases? I could be wrong about this though

EDIT: Err... we don't need to specify this since they'll just be passing the whole request object in.

I might say "Do not override the hostname in the request or use a hostname that differs from your own"?

:::

#### Parameters


Expand Down Expand Up @@ -156,6 +160,10 @@ The `stale-while-revalidate` and `stale-if-error` directives are not supported w

:::

:::note
Do not use dynamic or invalid hostnames in cache requests. This can cause DNS cache failures and latency.
:::

#### Parameters


Expand Down
Loading