Skip to content

Conversation

@deadlypants1973
Copy link
Contributor

@deadlypants1973 deadlypants1973 commented Dec 14, 2024

Merge on MONDAY DECEMBER 23, 2024 ONLY

Summary

14161

Screenshots (optional)

tbd

Documentation checklist

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 14, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a55abf6
Status: ✅  Deploy successful!
Preview URL: https://a5a82155.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://kate-fixes-perappvpn.cloudflare-docs-7ou.pages.dev

View logs

@j-bibodi
Copy link

I have 3 comments:

  1. From my observation in the past, we have not attached screenshots for configuring the steps. I am much in favor of adding the screenshots but based on @kkrum approval.

  2. Should we also add how to get the package name or app identifier for a specific app? This will help admins to not make any mistakes while entering the tunneled app package name. For example: we get the package name or app identifier from the ID query param in the Play store URL - https://play.google.com/store/apps/details?id=com.cloudflare.cloudflareoneagent

  3. The JSON object shared in the example shows Chrome browser and Gmail app package name, would it be ok to publish the 3rd party app identifier in our documentation? I just want to explicitly callout and get approval for the same.

{
       "key": "app_identifier",
       "valueString": "com.android.chrome" # Application package name/unique bundle identifier for the Chrome app browser
},

Otherwise, LGTM!

@deadlypants1973
Copy link
Contributor Author

I have 3 comments:

  1. From my observation in the past, we have not attached screenshots for configuring the steps. I am much in favor of adding the screenshots but based on @kkrum approval.
  2. Should we also add how to get the package name or app identifier for a specific app? This will help admins to not make any mistakes while entering the tunneled app package name. For example: we get the package name or app identifier from the ID query param in the Play store URL - https://play.google.com/store/apps/details?id=com.cloudflare.cloudflareoneagent
  3. The JSON object shared in the example shows Chrome browser and Gmail app package name, would it be ok to publish the 3rd party app identifier in our documentation? I just want to explicitly callout and get approval for the same.
{
       "key": "app_identifier",
       "valueString": "com.android.chrome" # Application package name/unique bundle identifier for the Chrome app browser
},

Otherwise, LGTM!

  1. No screenshots is favored by docs team as well because dashboard screenshots like this often go out of date very fast and it's better to have only text instructions rather than a confusingly outdated screenshot. I will remove them all.

  2. I think that would be helpful. Could you write something and tell me where to include it in docs?

  3. It's meant to be an example of a possible value (in this case, Chrome), right? I don't see an issue with it.

@deadlypants1973 deadlypants1973 marked this pull request as ready for review December 19, 2024 13:46
@deadlypants1973 deadlypants1973 requested review from a team, kkrum and ranbel as code owners December 19, 2024 13:46
}
]
}
```
Copy link
Contributor Author

@deadlypants1973 deadlypants1973 Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ ranbel A new sentence here on a new PR stating:

"
Refer to Per-app VPN parameters to learn more about the MDM parameters introduced to support the per-app VPN for Android devices.
"

after the parameters PR and this PR have been merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to #18896

@ranbel ranbel merged commit 341b5b2 into production Dec 20, 2024
12 checks passed
@ranbel ranbel deleted the kate/fixes-perappvpn branch December 20, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants