Skip to content

Conversation

@ousugo
Copy link
Contributor

@ousugo ousugo commented Dec 23, 2024

Summary

npm module executable "hexo" is no longer installed globally. Should migrate to using "npx hexo [args]"

Continuing to use hexo generate will result in deployment failure.

Screenshots (optional)

image

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

npm module executable "hexo" is no longer installed globally. Should migrate to using "npx hexo [args]"
@ToriLindsay
Copy link
Contributor

@dario-piotrowicz @jculvey @GregBrimble Would someone mind verifying this change and then I can merge?

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one minor comment, otherwise looks good to me, thanks for the fix @ousugo 🫶

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz @jculvey @GregBrimble Would someone mind verifying this change and then I can merge?

I've checked and the change is correct 👍, although as I commented I think that recommending users to run the build script would be better/more consistent with our other guides 🙂

@ToriLindsay ToriLindsay enabled auto-merge (squash) January 14, 2025 17:08
@ToriLindsay ToriLindsay merged commit e6219d2 into cloudflare:production Jan 14, 2025
6 checks passed
@ousugo ousugo deleted the patch-4 branch January 14, 2025 17:54
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Jan 14, 2025
@holopin-bot
Copy link

holopin-bot bot commented Jan 14, 2025

Congratulations @ousugo, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm5wt91xu96030cmkmidyl2fw

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes a docs contribution, big or small product:pages size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants