[Docs Site] Fix dark model styling in catalog components #19039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
KianNH
commented
Jan 7, 2025
| <input | ||
| type="text" | ||
| className="w-full mb-8 rounded-md bg-white dark:bg-black border-2 border-gray-200 dark:border-gray-700 px-2 py-2" | ||
| className="mb-8 w-full rounded-md border-2 border-gray-200 bg-white px-2 py-2 dark:border-gray-700 dark:bg-gray-800" |
Member
Author
There was a problem hiding this comment.
Most of the diff is formatting changes (we added the Tailwind plugin to help sort classes consistently), the changes are dark:bg-black being changed to dark:bg-gray-800.
github-actions
bot
assigned
GregBrimble,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Oxyjun
approved these changes
Jan 7, 2025
Deploying cloudflare-docs with
|
| Latest commit: |
f630448
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://efe0d5e4.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-15202.cloudflare-docs-7ou.pages.dev |
WalshyDev
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix dark model styling in catalog components
Screenshots (optional)
Before:
After: