[Workers] Document preview_urls config #19068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix routes config sections for new UI (custom domains already fixed) * add dash section for disabling workers.dev * add sections for disabling preview-urls * add `preview_urls` to wrangler config section
taylorlee
requested review from
a team,
GregBrimble,
ToriLindsay,
WalshyDev,
irvinebroque and
mikenomitch
as code owners
Deploying cloudflare-docs with
|
| Latest commit: |
2f270e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd870639.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://tlee-workers-add-preview-url.cloudflare-docs-7ou.pages.dev |
Contributor
WillTaylorDev
approved these changes
Jan 8, 2025
Contributor
WillTaylorDev
left a comment
WillTaylorDev
left a comment
There was a problem hiding this comment.
One small tweak LGTM!
GregBrimble
reviewed
Jan 8, 2025
GregBrimble
approved these changes
Jan 8, 2025
Co-authored-by: WillTaylorDev <[email protected]> Co-authored-by: Greg Brimble <[email protected]>
taylorlee
commented
Jan 8, 2025
taylorlee
commented
Jan 8, 2025
taylorlee
commented
Jan 8, 2025
taylorlee
commented
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Preview URL (beta) config was split from
workers.devin cloudflare/workers-sdk#7227 but never documented.Documentation checklist
ps. I rediscovered #18173 after making this pr. We can merge either?