-
Notifications
You must be signed in to change notification settings - Fork 10k
Document several missing compat flags #19129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document several missing compat flags #19129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 2 total issue(s) found.
src/content/compatibility-flags/disable-top-level-await-in-require.md
Outdated
Show resolved
Hide resolved
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
ToriLindsay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some grammar/clarity comments
src/content/compatibility-flags/disable-top-level-await-in-require.md
Outdated
Show resolved
Hide resolved
src/content/compatibility-flags/streams-transform-backpressure.md
Outdated
Show resolved
Hide resolved
src/content/compatibility-flags/streams-transform-backpressure.md
Outdated
Show resolved
Hide resolved
|
Hi @jasnell - I left some suggestions on this a while back. But other than that, is this ready to merge? Just checking since it's been sitting a while. Thanks! |
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryDocumented several compatibility flags related to Workers API behavior changes.
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
1 similar comment
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryDocumented several compatibility flags related to Workers API behavior changes.
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
src/content/compatibility-flags/disable-top-level-await-in-require.md
Outdated
Show resolved
Hide resolved
src/content/compatibility-flags/disable-top-level-await-in-require.md
Outdated
Show resolved
Hide resolved
src/content/compatibility-flags/disable-top-level-await-in-require.md
Outdated
Show resolved
Hide resolved
src/content/compatibility-flags/streams-transform-backpressure.md
Outdated
Show resolved
Hide resolved
src/content/compatibility-flags/streams-transform-backpressure.md
Outdated
Show resolved
Hide resolved
Co-authored-by: ToriLindsay <[email protected]>
|
discussed offline with Tori. She thinks it's ready to merge. |
Co-authored-by: ToriLindsay <[email protected]>
Co-authored-by: ToriLindsay <[email protected]>
Co-authored-by: ToriLindsay <[email protected]>
Co-authored-by: ToriLindsay <[email protected]>
Summary
Screenshots (optional)
Documentation checklist