Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Jan 13, 2025

Summary

Add a missing cache supported value

Ref:

@tewaro is this ok?

/cc @ToriLindsay

Documentation checklist

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 13, 2025

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c5b03e0
Status: ✅  Deploy successful!
Preview URL: https://90e36781.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://vb-branch-1.cloudflare-docs-7ou.pages.dev

View logs

@github-actions
Copy link
Contributor

@tewaro
Copy link
Contributor

tewaro commented Jan 13, 2025

The feature is still experimental. We do not support it yet because the necessary changes in pingora are not there. They are scheduled to happen soon. But until then what we have is just a sketch of the interface and will not work as expected.

Copy link
Contributor

@tewaro tewaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be delayed until we officially have a compat date for the no-cache changes.

@vicb vicb marked this pull request as draft January 13, 2025 17:24
@vicb
Copy link
Contributor Author

vicb commented Jan 13, 2025

Thanks for the review/feedback @tewaro.
I didn't pay attention that you only modified the experimental types on the PR.
Marking the PR as draft

@ToriLindsay ToriLindsay assigned kodster28 and unassigned ToriLindsay Jun 6, 2025
@tewaro
Copy link
Contributor

tewaro commented Aug 7, 2025

Supplanted by : #24245

@tewaro tewaro closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants