Skip to content

Conversation

@jasnell
Copy link
Contributor

@jasnell jasnell commented Jan 14, 2025

Refs: cloudflare/workerd#3311

Summary

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

hyperlint-ai[bot]

This comment was marked as outdated.

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added inline comments.

It would be great to add details to https://developers.cloudflare.com/workers/configuration/secrets/ -> mention the flag and process.env

Thanks

hyperlint-ai[bot]

This comment was marked as outdated.

hyperlint-ai[bot]

This comment was marked as outdated.

hyperlint-ai[bot]

This comment was marked as outdated.

@jasnell jasnell force-pushed the jasnell/doc-process-env branch from e4e19ef to 9220bba Compare July 31, 2025 17:05
@jasnell jasnell requested a review from vicb July 31, 2025 17:06
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be awesome is to document disallow_importable_env as well.

That is:

  • Create a file in src/content/compatibility-flags/
  • Link the flag where it is referenced in the content.

Thanks for documenting this 🎉

@jasnell
Copy link
Contributor Author

jasnell commented Jul 31, 2025

I will add disallow_importable_env in a separate PR (will add it here: #24083)

@jasnell jasnell force-pushed the jasnell/doc-process-env branch from 4eb6c56 to c2f757e Compare August 12, 2025 22:40
@jasnell jasnell enabled auto-merge (squash) August 12, 2025 22:43
@jasnell jasnell merged commit e5285f0 into cloudflare:production Aug 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s