[Docs Site] Fix isCurrent sidebar item on custom pages and nested hideChildren pages #19217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
Deploying cloudflare-docs with
|
| Latest commit: |
fe71b0c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f77be0ac.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-15348.cloudflare-docs-7ou.pages.dev |
github-actions
bot
assigned
GregBrimble,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
pedrosousa
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix isCurrent sidebar item on custom pages and nested hideChildren pages.
Astro.params.slugisundefinedon custom pages, such as those used by Workers AI models.Some pages do not exist on the sidebar, i.e those in a
hideChildrenfolder, and this will still highlight the parent page.Screenshots (optional)
Before:
After:
