-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Workers for Platforms docs: Improved dispatch Worker description #19232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RebeccaTamachiro
merged 4 commits into
cloudflare:production
from
dinasaur404:update-dispatch-worker-docs
Jan 22, 2025
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2c2fb0e
docs: improve dispatch Worker description
dinasaur404 b75bcd7
Update src/content/docs/cloudflare-for-platforms/workers-for-platform…
dinasaur404 6d2277b
Update src/content/docs/cloudflare-for-platforms/workers-for-platform…
dinasaur404 5b69226
Update src/content/docs/cloudflare-for-platforms/workers-for-platform…
dinasaur404 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never loved this "dispatch Worker" phrasing. It makes it seem like this Worker is special, when it really isn't, and I've seen that confuse users a few times now. This is just a regular Worker which happens to have a WfP namespace binding. I can choose to call a user Worker in that namespace, possibly with a request over
fetch. But I don't have to, and it's not like I concede everything over to it when I do so. I can do other stuff before and after calling it! I can do RPC!It's fine in a guide specifically about how to create a hosting platform where this request-delegation is the pattern, but using it as the "getting started" guide for all of Workers for Platforms does WfP a disservice, imo. It doesn't very accurately portray a setup for hosted bots, or LLM-authored script isolation/tool calling or anything like that.