[Docs Site] Refactor rehype plugins #19360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
dcpena,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa,
WalshyDev and
dcpena
Deploying cloudflare-docs with
|
| Latest commit: |
188f05d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e2a80188.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-15463.cloudflare-docs-7ou.pages.dev |
Contributor
kodster28
approved these changes
Jan 23, 2025
deadlypants1973
pushed a commit
that referenced
this pull request
Jan 29, 2025
* [Docs Site] Refactor rehype plugins * fix closing tag in anchorheading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors rehype plugins to be configured outside of
astro.config.ts.Removes dependency on
rehype-mermaid(and by extensionplaywright) in favour of the minimal code we needed from that plugin for thepre-mermaidstrategy.Components or scripts that need to handle our external link icon,
" ↗", can now do so by importingrehypeExternalLinksOptionsfrom~/plugins/rehype/external-linksand accessingrehypeExternalLinksOptions.content.valueor by using theexternal-linkclass.As a user of the site, the only change is the addition of the
external-linkclass.