[Docs Site] Set eslint in CI to use filter_mode: nofilter #19444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
GregBrimble,
WalshyDev,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Deploying cloudflare-docs with
|
| Latest commit: |
d9b3202
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4c4d6cd5.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-15539.cloudflare-docs-7ou.pages.dev |
Member
Author
|
Error is successfully picked up 
|
WalshyDev
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set eslint in CI to use filter_mode: nofilter. This stops errors from getting past reviewdog which would later be caught by
npx eslint .locally.