Updates dns docs to not use unimplemented method #19564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenomitch
force-pushed
the
mnomitch/update-dns-example
branch
from
e6fd3f6 to
5bb5587
Compare
mikenomitch
requested review from
a team,
ToriLindsay,
elithrar,
irvinebroque,
jasnell,
jonesphillip and
rita3ko
as code owners
mikenomitch
force-pushed
the
mnomitch/update-dns-example
branch
from
5bb5587 to
96644e0
Compare
github-actions
bot
assigned
elithrar,
irvinebroque,
jonesphillip,
rita3ko,
jasnell and
ToriLindsay
irvinebroque
approved these changes
Jan 30, 2025
Deploying cloudflare-docs with
|
| Latest commit: |
96644e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63847d75.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://mnomitch-update-dns-example.cloudflare-docs-7ou.pages.dev |
Contributor
|
Files with changes (up to 15)
|
kodster28
pushed a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Accidentally used
lookupin my example even tho it's not implemented 🤦 .Using the resolve4 promise because it works and the promise UX seems slightly nicer IMO.
Confirmed that this works with latest wrangler.