[Docs Site] Support paths with and without trailing slash in local dev #19596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
WalshyDev,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Deploying cloudflare-docs with
|
| Latest commit: |
1859d12
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5446624.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-15650.cloudflare-docs-7ou.pages.dev |
kodster28
approved these changes
Jan 31, 2025
Collaborator
kodster28
left a comment
kodster28
left a comment
There was a problem hiding this comment.
Oooh, ty!
This is very annoying b/c otherwise we sometimes have to do double redirects for each version.
I should really set aside time quarterly to review our config options 😓
Contributor
|
Consider |
KianNH
force-pushed
the
kian/PCX-15650
branch
from
1859d12 to
c9dfa44
Compare
KianNH
changed the title
Contributor
|
Preview URL: https://c9dfa445.preview.developers.cloudflare.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was highlighted by a chance in our sidebar logic - we shouldn't "support" links like
/workersand should direct people to/workers/as all links and redirects written should use the trailing slash.