Update docs https://developers.cloudflare.com/workers/static-assets/#limitations to reflect an error is now a warning. #19691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Limitation bullet 3. CF/Wrangler no longer seems to error but just warn if you have a worker with an asset binding and deploy on a route with a path component.
michielkikkert
requested review from
a team,
GregBrimble,
ToriLindsay,
WalshyDev and
irvinebroque
as code owners
michielkikkert
changed the title
GregBrimble
reviewed
Feb 3, 2025
Applied suggestion Co-authored-by: Greg Brimble <[email protected]>
GregBrimble
approved these changes
Feb 3, 2025
Author
|
Is there still something I need to do to get this merged? |
ToriLindsay
approved these changes
Feb 13, 2025
Contributor
|
@michielkikkert ! Thank you for the feedback about how we can make improvements with developers.cloudflare.com documentation. Closing this as a duplicate of a change that has since been made. |
Author
|
I see the Limitations section has now been moved to a different page. The mistake is still in there I see? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Limitation bullet 3. CF/Wrangler no longer seems to error but just warn if you have a worker with an asset binding and deploy on a route with a path component.
Summary
https://developers.cloudflare.com/workers/static-assets/#limitations, bullet 3.
Screenshots (optional)
Documentation checklist