Made json first in wrangler component #19718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToriLindsay
requested review from
a team,
GregBrimble,
KianNH,
WalshyDev,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
KianNH,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Contributor
Author
|
@KianNH Would you mind reviewing? |
Deploying cloudflare-docs with
|
| Latest commit: |
979ee50
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ee68c351.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://tori-pcx15588-make-json-firs.cloudflare-docs-7ou.pages.dev |
KianNH
approved these changes
Feb 4, 2025
Member
KianNH
left a comment
KianNH
left a comment
There was a problem hiding this comment.
Yep, that's all there is to it!
ToriLindsay
deleted the
tori/pcx15588-make-json-first-in-wrangler-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from @Oxyjun (Thank you!)
The
<WranglerConfig>component is a component which automatically creates ajsonequivalent for thewrangler.tomlfile. However, the component currently shows thewrangler.tomltab beforewrangler.json(i.e. when a user lands on a page, they'll seewrangler.tomlunless they explicitly choose to switch towrangler.json.It may be better to show
wrangler.jsonfirst, if we're moving away from using.toml(for example, C3 now createswrangler.jsonby default, so for new users, this will be the more natural option going forward.