-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Docs Site] Refactor partials property validation and docs #19887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eed0cc5 to
c744631
Compare
maxvp
reviewed
Feb 12, 2025
| :::caution | ||
| This component does not use Astro to render the Markdown, as a result it cannot use components, `~/assets/` images or code blocks. | ||
|
|
||
| Where feasible, use [JSX](/style-guide/components/render/#properties-in-markdown-syntax) instead |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| Where feasible, use [JSX](/style-guide/components/render/#properties-in-markdown-syntax) instead | |
| Where feasible, use [JSX](/style-guide/components/render/#properties-in-markdown-syntax) instead. |
maxvp
approved these changes
Feb 12, 2025
3cf8909 to
37a5770
Compare
37a5770 to
ad4c0ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recreation of #19721 which was reverted in #19880