-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Workers] Add "internal error id" entry to Workers and DO changelogs #19923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview URL: https://070dcf85.preview.developers.cloudflare.com |
vy-ton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| entries: | ||
| - publish_date: "2025-02-11" | ||
| description: |- | ||
| - When the runtime generates an "internal error" exception in response to certain failures, the exception message may include a reference ID that customers can include in support communication, to help make the error easier to diagnose. For example, an exception with the new message might look like: `internal error; reference = 0123456789abcdefghijklmn`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - When the runtime generates an "internal error" exception in response to certain failures, the exception message may include a reference ID that customers can include in support communication, to help make the error easier to diagnose. For example, an exception with the new message might look like: `internal error; reference = 0123456789abcdefghijklmn`. | |
| - When Durable Objects generate an "internal error" exception in response to certain failures, the exception message may include a reference ID that customers can include in support communication, to help make the error easier to diagnose. For example, an exception with the new message might look like: `internal error; reference = 0123456789abcdefghijklmn`. |
@jclee Why may include? Are there internal errors that won't have a reference ID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think as currently implemented, most exceptions that were generated with the text "internal error" will have the reference id.
There is one remaining "internal error" exception that requires more work to add the reference id, but I think it is only generated in rare circumstances, like worker startup exceptions that we'd expect to be detected during worker validation, before they reach the edge.
And there are some other instances where we generate similar but more verbose exceptions -- like jsg.Error: Internal error in Durable Object storage write caused object to be reset. -- that we may want to also add reference ids to, but that are not affected by the current implementation.
Co-authored-by: Vy Ton <[email protected]>
Co-authored-by: Vy Ton <[email protected]>
Summary
Adds entries to the Workers and DO changelogs describing a change to "internal error" exception messages to include "reference" ids.
Documentation checklist