Skip to content

[Workers] Add "internal error id" entry to Workers and DO changelogs #19923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 13, 2025
+6 −0
Merged

[Workers] Add "internal error id" entry to Workers and DO changelogs #19923

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b38b8e0
[Workers] Add "internal error id" entry to Workers and DO changelogs
jclee Feb 11, 2025
2ff4d87
Update src/content/changelogs/durable-objects.yaml
jclee Feb 12, 2025
7af1a92
Update src/content/changelogs/workers.yaml
jclee Feb 12, 2025
c51b152
Update src/content/changelogs/workers.yaml
Oxyjun Feb 13, 2025
8c4d5ca
Update src/content/changelogs/durable-objects.yaml
Oxyjun Feb 13, 2025
8eab031
Update src/content/changelogs/durable-objects.yaml
Oxyjun Feb 13, 2025
070dcf8
Update src/content/changelogs/durable-objects.yaml
Oxyjun Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/content/changelogs/durable-objects.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ productLink: "/durable-objects/"
productArea: Developer platform
productAreaLink: /workers/platform/changelog/platform/
entries:
- publish_date: "2025-02-11"
description: |-
- When the runtime generates an "internal error" exception in response to certain failures, the exception message may include a reference ID that customers can include in support communication, to help make the error easier to diagnose. For example, an exception with the new message might look like: `internal error; reference = 0123456789abcdefghijklmn`.
Copy link
Contributor

@vy-ton vy-ton Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- When the runtime generates an "internal error" exception in response to certain failures, the exception message may include a reference ID that customers can include in support communication, to help make the error easier to diagnose. For example, an exception with the new message might look like: `internal error; reference = 0123456789abcdefghijklmn`.
- When Durable Objects generate an "internal error" exception in response to certain failures, the exception message may include a reference ID that customers can include in support communication, to help make the error easier to diagnose. For example, an exception with the new message might look like: `internal error; reference = 0123456789abcdefghijklmn`.

@jclee Why may include? Are there internal errors that won't have a reference ID?

Copy link
Contributor Author

@jclee jclee Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as currently implemented, most exceptions that were generated with the text "internal error" will have the reference id.

There is one remaining "internal error" exception that requires more work to add the reference id, but I think it is only generated in rare circumstances, like worker startup exceptions that we'd expect to be detected during worker validation, before they reach the edge.

And there are some other instances where we generate similar but more verbose exceptions -- like jsg.Error: Internal error in Durable Object storage write caused object to be reset. -- that we may want to also add reference ids to, but that are not affected by the current implementation.

- publish_date: "2024-10-07"
title: Alarms re-enabled in (beta) SQLite-backed Durable Object classes
description: |-
Expand Down
3 changes: 3 additions & 0 deletions src/content/changelogs/workers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ productLink: "/workers/"
productArea: Developer platform
productAreaLink: /workers/platform/changelog/platform/
entries:
- publish_date: "2025-02-11"
description: |-
- When the runtime generates an "internal error" exception in response to certain failures, the exception message may include a reference ID that customers can include in support communication, to help make the error easier to diagnose. For example, an exception with the new message might look like: `internal error; reference = 0123456789abcdefghijklmn`.
- publish_date: "2025-01-31"
description: |-
- Updated v8 to version 13.3.
Expand Down
Loading