[Magic, several] Work to consolidate partials with conditional rendered content #19935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conditinal render partiasl
KianNH
reviewed
Feb 12, 2025
Member
KianNH
left a comment
KianNH
left a comment
There was a problem hiding this comment.
Awesome work!
My comments are all stylistic or personal preference, so up to you on how you want to format the partials.
|
|
||
| | Prefix | NextHop | Priority | Weight | | ||
| | ----------------- | -------------- | -------- | ------ | | ||
| | `10.10.10.100/24` | `TUNNEL_1_IAD` | `100` | `64` | |
Member
There was a problem hiding this comment.
Suggested change
| | `10.10.10.100/24` | `TUNNEL_1_IAD` | `100` | `64` | | |
| | `10.10.10.100/24` | `TUNNEL_1_IAD` | `100` | `64` | |
Comment on lines
+59
to
+60
| | Prefix | NextHop | | ||
| | ----------------- | -------------- | |
Member
There was a problem hiding this comment.
Suggested change
| | Prefix | NextHop | | |
| | ----------------- | -------------- | | |
| | Prefix | NextHop | | |
| | ----------------- | -------------- | |
Comment on lines
+14
to
+16
| <> | ||
| <p>For Magic WAN Connector, health checks are sent to IPsec tunnel endpoints.</p> | ||
| </> |
Member
There was a problem hiding this comment.
You can omit technically <> and </> if there is only a single element, but you might prefer to keep it as it's easier to consistently stick with it regardless - up to you!
No fragment needed:
<p>
<strong>text</strong>
</p>Fragment needed:
<>
<p>thing</p>
<p>thing2</p>
</>| { props.magicProduct === "Magic WAN" && ( | ||
| <> | ||
| <AnchorHeading depth={2} title="Configure Connector" /> | ||
| <ol><li>Log in to the <a href='https://dash.cloudflare.com/'>Cloudflare dashboard</a> and select your account.</li><li>Go to <strong>Magic WAN</strong> {'>'} <strong>Sites</strong>.</li><li>Select your site {'>'} <strong>Edit</strong>.</li><li>In <strong>Network</strong> {'>'} <strong>WAN configuration</strong> {'>'} select your WAN {'>'} <strong>Edit</strong>.</li><li>Change the <strong>Health check rate</strong> to your desire rate.</li><li>Select <strong>Save</strong>.</li></ol> |
Member
There was a problem hiding this comment.
This could be formatted like so, but the caveat is needing to use {" "} to indicate spaces between elements on different lines.
<>
<AnchorHeading depth={2} title="Configure Connector" />
<ol>
<li>
Log in to the{" "}
<a href="https://dash.cloudflare.com/">Cloudflare dashboard</a> and select
your account.
</li>
<li>
Go to <strong>Magic WAN</strong> {">"} <strong>Sites</strong>.
</li>
<li>
Select your site {">"} <strong>Edit</strong>.
</li>
<li>
In <strong>Network</strong> {">"} <strong>WAN configuration</strong> {">"}{" "}
select your WAN {">"} <strong>Edit</strong>.
</li>
<li>
Change the <strong>Health check rate</strong> to your desire rate.
</li>
<li>
Select <strong>Save</strong>.
</li>
</ol>
</>
Contributor
Oxyjun
approved these changes
Feb 12, 2025
jonesphillip
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ed content (#19935) * added content from all partials in static-routes1 * corrected code * deleted unnecessary static routes partials * renamed partial * moved staticroutes outside folder * added optional vars * added conditional vars * removed extra vars * changed to hmtl * removed extra space * created overview partial * corrected vars * corrected vars * added indenting * added all content to same partial * corrected code * deletes old partials * deletes old partials mwan * moves mtu out of folder * corrected partial path * added partials for clamping conditinal render partiasl * removed extra space * added gre ipsec partials mwan * added optional vars to mt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Documentation checklist