-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Stream] Various Updates #19980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stream] Various Updates #19980
Conversation
src/content/changelog/stream/2025-02-14-introducing-dvr-for-stream-live.mdx
Outdated
Show resolved
Hide resolved
| offering this feature as an opt-in adjustment, our customers are empowered to | ||
| pick the best experiences for their applications. | ||
|
|
||
| ## How to get started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about removing this section and just linking to the docs? This will tighten up the changelog entry and ensure that if the example changes for whatever reason, you're not updating it in two places or forgetting one of them and getting in a spot with two example verisons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point! Can I split the difference with you? Remove the example code and the subhead, but retain the key sentence:
When building a player embed code or manifest URL, just add
dvrEnabled=trueas
a query parameter.
since I want to get across 1) you have to do this to make it work, but 2) it is literally only just this little thing and that's nifty.
src/content/changelog/stream/2025-02-14-introducing-dvr-for-stream-live.mdx
Outdated
Show resolved
Hide resolved
…ream-live.mdx Co-authored-by: Denise Peña <[email protected]>
Co-authored-by: Denise Peña <[email protected]>
Co-authored-by: Denise Peña <[email protected]>
Co-authored-by: Denise Peña <[email protected]>
…ith/stream-20250212
73eb550 to
0248e86
Compare
|
|
||
| - When using DVR Mode and a player/manifest created using a Live Input ID, the | ||
| player may stall when trying to switch quality levels if a viewer is still | ||
| watching after a broadcast has concluded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this temporary? Is the solution also going to go live w/ the feature? (I may be remembering incorrectly!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would depend on if the player had pre-fetched a rendition manifest that it wasn't playing. Because the Live Input ID does not refer to a past broadcast, fetching an updated manifest after the broadcast concludes will result in an HTTP 204. We will go forward with this limitation accepted, and see if folks run into it. This is why we recommend using DVR with a Video ID when possible.
kodster28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog image would be nice
Summary
Screenshots (optional)
Documentation checklist