Skip to content

Conversation

@tsmith512
Copy link
Contributor

Summary

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@tsmith512 tsmith512 requested a review from a team as a code owner February 13, 2025 20:09
offering this feature as an opt-in adjustment, our customers are empowered to
pick the best experiences for their applications.

## How to get started
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about removing this section and just linking to the docs? This will tighten up the changelog entry and ensure that if the example changes for whatever reason, you're not updating it in two places or forgetting one of them and getting in a spot with two example verisons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point! Can I split the difference with you? Remove the example code and the subhead, but retain the key sentence:

When building a player embed code or manifest URL, just add dvrEnabled=true as
a query parameter.

since I want to get across 1) you have to do this to make it work, but 2) it is literally only just this little thing and that's nifty.

@tsmith512 tsmith512 force-pushed the tsmith/stream-20250212 branch from 73eb550 to 0248e86 Compare February 14, 2025 05:17

- When using DVR Mode and a player/manifest created using a Live Input ID, the
player may stall when trying to switch quality levels if a viewer is still
watching after a broadcast has concluded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this temporary? Is the solution also going to go live w/ the feature? (I may be remembering incorrectly!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would depend on if the player had pre-fetched a rendition manifest that it wasn't playing. Because the Live Input ID does not refer to a past broadcast, fetching an updated manifest after the broadcast concludes will result in an HTTP 204. We will go forward with this limitation accepted, and see if folks run into it. This is why we recommend using DVR with a Video ID when possible.

@tsmith512 tsmith512 marked this pull request as ready for review February 14, 2025 18:08
@tsmith512 tsmith512 enabled auto-merge (squash) February 14, 2025 18:09
Copy link
Collaborator

@kodster28 kodster28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog image would be nice

@tsmith512 tsmith512 merged commit e11c3ee into production Feb 14, 2025
11 checks passed
@tsmith512 tsmith512 deleted the tsmith/stream-20250212 branch February 14, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:stream Related to Stream product size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants