Skip to content

Conversation

@KianNH
Copy link
Member

@KianNH KianNH commented Feb 21, 2025

Summary

This enables loading filters from search parameters, like /products/ and /ruleset-engine/rules-language/fields/reference/, such as ?search=facebook&tasks=Summarization

Screenshots (optional)

image

@github-actions
Copy link
Contributor

Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

@github-actions
Copy link
Contributor

Copy link
Collaborator

@kodster28 kodster28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is an improvement... but for both this / the fields grid, it looks like we aren't updating the URL when the filters change.

Can track as a separate ask.

@pedrosousa
Copy link
Contributor

So this is an improvement... but for both this / the fields grid, it looks like we aren't updating the URL when the filters change.

Can track as a separate ask.

+1
Yes, we're still missing this part. Having the possibility of clearing the search box (usually using an "X" at the end of the input box) could also be handy.

@KianNH KianNH merged commit 2505d02 into production Feb 24, 2025
11 checks passed
@KianNH KianNH deleted the kian/PCX-16036 branch February 24, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants