-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[DO] Clarifying DO creation behaviour with location hint #20348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd take this out of a caution block, since this is a good thing. I'd just get rid of this block together, and add it to one of the paragraphs above. E.g.:
"To manually create Durable Objects in another location, provide an optional locationHint parameter to get(). The Durable Object is guaranteed to be created in the specified region. ..."
This seems better to me, because the "If the location hint cannot be respected" failure condition doesn't really exist in our codebase as it stands. We don't go over all possible locations in a region to store your Durable Object. We just try a location, and if it fails, your request fails in the same way that any Durable Object request can fail. That's also why I would drop the bit about a retryable operation. Not all errors you get when specifying a location hint are retryable. E.g. you can get an overloaded exception back, just like you can without a location hint, and those should generally not be retried.