Skip to content

Conversation

@bodadotsh
Copy link
Contributor

Summary

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions
Copy link
Contributor

Howdy and thanks for contributing to our repo. We review new, external PRs within 2 weeks. If it's been longer than then without any movement, tag the PR Assignees in a comment.

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 3, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated the fetch-json example to ensure proper handling of response text by adding missing await statements.

  • Added missing await for response.text() in the fetch-json example
  • Ensured consistent handling of response data in the documentation
  • Improved code accuracy for better user understanding

Modified Files

  • src/content/docs/workers/examples/fetch-json.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@kodster28 kodster28 enabled auto-merge (squash) April 3, 2025 12:53
@kodster28 kodster28 merged commit a153375 into cloudflare:production Apr 3, 2025
6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Apr 3, 2025
@holopin-bot
Copy link

holopin-bot bot commented Apr 3, 2025

Congratulations @bodadotsh, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm91dawpz62860clhehidlzlu

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@bodadotsh bodadotsh deleted the patch-5 branch April 4, 2025 09:20
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
* missing await for response.text()

* Retrigger CI

* Retrigger CI

---------

Co-authored-by: boda <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bad-example contribution [Holopin] Recognizes a docs contribution, big or small product:workers Related to Workers product size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants