-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Vite plugin docs #20481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite plugin docs #20481
Conversation
|
Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyperlint Review is complete!
Hyperlint Vale Style Guide Review
Reviewed 7 files and found 2 issues.
See the inline comments and suggestions below.
Hyperlint Link Check Review
Reviewed 7 files and found 0 issues.
We are upgrading our reviewer model! Going forward, our model will learn your particular style - which comments you all accept and reject, so that it can further personalize its suggestions.
What is Hyperlint?
Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. It can review, edit, and suggest fixes for your documentation.
Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.
faa371a to
c401edd
Compare
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryDrafted comprehensive documentation for the Vite plugin, enhancing user guidance and integration with Cloudflare environments.
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
c401edd to
d89872d
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First lot of comments before lunch 😄
src/content/docs/workers/vite-plugin/cloudflare-environments.mdx
Outdated
Show resolved
Hide resolved
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Left a few more comments. I am done now.
Thanks for powering through this @jamesopstad
src/content/docs/workers/vite-plugin/cloudflare-environments.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/vite-plugin/migrating-from-wrangler-dev.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/vite-plugin/migrating-from-wrangler-dev.mdx
Outdated
Show resolved
Hide resolved
bac5c2b to
ab0126f
Compare
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
ab0126f to
ddb1c6c
Compare
Thanks for the feedback @petebacondarwin. I've made all the suggested changes except the ones I've left unresolved. |
|
|
||
| ### Use cases | ||
|
|
||
| - React Router v7 (support for more full-stack frameworks is coming soon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful to break down the kinds of applications that can be built. Such as:
- Single-page applications
- Static sites
- Server-side rendered applications (The Vite plugin is currently only supported in React Router v7, with more full-stack frameworks support coming soon).
| {/* Add docs for _headers and _redirects */} | ||
|
|
||
| :::note | ||
| The Cloudflare Vite plugin does not support [run_worker_first](/workers/static-assets/binding/#run_worker_first). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only when running dev or any other commands? Also, should we call out any nuances with _headers and _redirects ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to reference _headers and _redirects but I couldn't find any docs to link to. I've left a comment and can add this in later.
While run_worker_first is technically supported in preview and deploy, I think we'll add a warning against using it because the behaviour in dev would be very different.
korinne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, but they don't need to be addressed before merging. This looks great, thanks James!
kodster28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few broad things. This is good though!
Structural feedback:
I'd prefer that we add a touch more hierarchy here, maybe something like:
Overview
Get started
Tutorial - React SPA
Reference (contains everything else, or at least more of the reference type content)
Writing feedback:
- Added a lot of cross links. In most places, we'd prefer you have cross links in context instead of having an additional line like
See X for more details. - Code blocks support
title=""values. Seems like you could benefit from those across your examples. - Separate runnable commands into their own code block. Really good for copy / paste && actionability.
Summary
Documentation for the Vite plugin
Screenshots (optional)
Documentation checklist