Skip to content

Conversation

@mikenomitch
Copy link
Contributor

@mikenomitch mikenomitch commented Mar 7, 2025

Summary

Adds process.env population changelog and flag info

Also, we should update this page: https://developers.cloudflare.com/workers/configuration/environment-variables/

But going to way until the importable env change is rolled out to update it in one swoop with both new methods.

@mikenomitch mikenomitch requested review from a team, GregBrimble and irvinebroque as code owners March 7, 2025 22:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Think you added extra bonus changelog (guessing for different PR)

@mikenomitch mikenomitch force-pushed the mikenomitch/add-process-env-docs branch from 68f7f7c to 2562375 Compare March 11, 2025 05:18
@github-actions github-actions bot added the product:workers Related to Workers product label Mar 11, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 11, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Enhanced documentation for process.env population and compatibility flags in Workers.

  • Added changelog entry for process.env population with Node.js compatibility.
  • Introduced compatibility flag for auto-populating process.env with environment variables.
  • Updated documentation to clarify the behavior of process.env in Workers.

Modified Files

  • src/content/docs/workers/runtime-apis/nodejs/process.mdx

Added Files

  • src/content/changelog/workers/2025-03-11-process-env-support.mdx
  • src/content/compatibility-flags/nodejs-compat-populate-process-env.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

@mikenomitch mikenomitch force-pushed the mikenomitch/add-process-env-docs branch from 93454fe to 0655d8f Compare March 11, 2025 14:07
@mikenomitch mikenomitch enabled auto-merge (squash) March 11, 2025 14:07
@mikenomitch mikenomitch merged commit dc4ef68 into production Mar 11, 2025
11 checks passed
@mikenomitch mikenomitch deleted the mikenomitch/add-process-env-docs branch March 11, 2025 14:19
@raghavsethi
Copy link

raghavsethi commented Mar 12, 2025

Hey @mikenomitch, thanks for this change, but I think there might be a missing step in here? I can't get the flag to work based on these instructions. Details are here - https://community.cloudflare.com/t/the-new-process-env-support-in-cloudflare-workers-does-not-work-properly/778592/2

RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
Adds changelog and flag information for process.env population
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants