Skip to content

thomasgauvin: add examples to workers kv #20655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 27, 2025
Merged

thomasgauvin: add examples to workers kv #20655

merged 10 commits into from
Mar 27, 2025

Conversation

@thomasgauvin
Copy link
Contributor

@thomasgauvin thomasgauvin commented Mar 8, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025

Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 8, 2025 •
edited
Loading

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Enhanced Workers KV documentation with new examples and improved clarity on usage.

  • Added examples for caching data, distributed configuration, A/B testing, and routing with Workers KV.
  • Updated existing example for serving static assets with improved explanations.
  • Modified related resources to include links to new examples.

Modified Files

  • src/content/docs/kv/examples/workers-kv-to-serve-assets.mdx
  • src/content/docs/kv/index.mdx
  • src/content/docs/reference-architecture/diagrams/serverless/a-b-testing-using-workers.mdx

Added Files

  • src/content/docs/kv/examples/cache-data-with-workers-kv.mdx
  • src/content/docs/kv/examples/distributed-configuration-with-workers-kv.mdx
  • src/content/docs/kv/examples/implement-ab-testing-with-workers-kv.mdx
  • src/content/docs/kv/examples/routing-with-workers-kv.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025 •
edited
Loading

Preview URL: https://c222fffb.preview.developers.cloudflare.com
Preview Branch URL: https://thomasgauvin-add-workers-kv-examples.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/kv/examples/workers-kv-to-serve-assets/ https://thomasgauvin-add-workers-kv-examples.preview.developers.cloudflare.com/kv/examples/workers-kv-to-serve-assets/
https://developers.cloudflare.com/kv/examples/distributed-configuration-with-workers-kv/ https://thomasgauvin-add-workers-kv-examples.preview.developers.cloudflare.com/kv/examples/distributed-configuration-with-workers-kv/
https://developers.cloudflare.com/kv/examples/routing-with-workers-kv/ https://thomasgauvin-add-workers-kv-examples.preview.developers.cloudflare.com/kv/examples/routing-with-workers-kv/
https://developers.cloudflare.com/kv/examples/cache-data-with-workers-kv/ https://thomasgauvin-add-workers-kv-examples.preview.developers.cloudflare.com/kv/examples/cache-data-with-workers-kv/
https://developers.cloudflare.com/kv/examples/implement-ab-testing-with-workers-kv/ https://thomasgauvin-add-workers-kv-examples.preview.developers.cloudflare.com/kv/examples/implement-ab-testing-with-workers-kv/
https://developers.cloudflare.com/reference-architecture/diagrams/serverless/a-b-testing-using-workers/ https://thomasgauvin-add-workers-kv-examples.preview.developers.cloudflare.com/reference-architecture/diagrams/serverless/a-b-testing-using-workers/
https://developers.cloudflare.com/kv/ https://thomasgauvin-add-workers-kv-examples.preview.developers.cloudflare.com/kv/

Oxyjun
Oxyjun reviewed Mar 10, 2025
View reviewed changes
Oxyjun
Oxyjun reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@Oxyjun Oxyjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCX review

@github-actions github-actions bot added size/xl and removed size/l labels Mar 13, 2025
hyperlint-ai[bot]
hyperlint-ai bot reviewed Mar 13, 2025
View reviewed changes
@thomasgauvin @hyperlint-ai
Update src/content/docs/kv/examples/cache-data-with-workers-kv.mdx
bff8da0 
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
thomasgauvin
thomasgauvin commented Mar 14, 2025
View reviewed changes
thomasgauvin
thomasgauvin commented Mar 14, 2025
View reviewed changes
src/content/docs/kv/examples/cache-data-with-workers-kv.mdx Outdated

:::note[Note]

You can also cache data in Workers with the [Cache API](https://developers.cloudflare.com/workers/runtime-apis/cache/). With the Cache API,
Copy link
Contributor Author

@thomasgauvin thomasgauvin Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can also cache data in Workers with the [Cache API](https://developers.cloudflare.com/workers/runtime-apis/cache/). With the Cache API,
You can also cache data in Workers with the [Cache API](/workers/runtime-apis/cache/). With the Cache API,

thomasgauvin
thomasgauvin commented Mar 14, 2025
View reviewed changes
@thomasgauvin thomasgauvin merged commit 4beefe2 into production Mar 27, 2025
11 of 12 checks passed
@thomasgauvin thomasgauvin deleted the thomasgauvin-add-workers-kv-examples branch March 27, 2025 15:58
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
@thomasgauvin @Oxyjun
@hyperlint-ai @RebeccaTamachiro
thomasgauvin: add examples to workers kv (#20655)
8dd6db5 
* thomasgauvin: add examples to workers kv

* Apply suggestions from code review

Style guide alignment

* Update src/content/docs/kv/examples/routing-with-workers-kv.mdx

* Update src/content/docs/kv/examples/distributed-configuration-with-workers-kv.mdx

* thomasgauvin: update caching with kv vs cache api

* Update src/content/docs/kv/examples/cache-data-with-workers-kv.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* Update src/content/docs/kv/examples/cache-data-with-workers-kv.mdx

* Update src/content/docs/kv/examples/cache-data-with-workers-kv.mdx

---------

Co-authored-by: Jun Lee <[email protected]>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oxyjun Oxyjun Oxyjun approved these changes

@securitypedant securitypedant Awaiting requested review from securitypedant securitypedant is a code owner

@haleycode haleycode Awaiting requested review from haleycode haleycode is a code owner

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@rts-rob rts-rob Awaiting requested review from rts-rob

+1 more reviewer

@hyperlint-ai hyperlint-ai[bot] hyperlint-ai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elithrar elithrar

@rts-rob rts-rob

@securitypedant securitypedant

@haleycode haleycode

@Oxyjun Oxyjun

Labels

product:kv product:reference-architecture size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thomasgauvin @Oxyjun @elithrar @rts-rob @securitypedant @haleycode