Skip to content

Conversation

@marciocloudflare
Copy link
Contributor

@marciocloudflare marciocloudflare commented Mar 11, 2025

Summary

  • Continues work for PCX-15975
  • Now that we have conditional rendering, I've moved all content to one page, since breakout traffic and priority traffic are basically the same content with a few exceptions

Documentation checklist

@marciocloudflare marciocloudflare requested a review from a team as a code owner March 11, 2025 16:45
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 11, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Consolidated content for Breakout and Prioritized traffic into a single page with conditional rendering.

  • Merged Breakout traffic and Prioritized traffic documentation into one page for better clarity.
  • Implemented conditional rendering to display relevant information based on traffic type.
  • Updated API request examples for adding and deleting applications under the new structure.

Modified Files

  • src/content/docs/magic-wan/configuration/connector/network-options/application-based-policies/breakout-traffic.mdx
  • src/content/docs/magic-wan/configuration/connector/network-options/application-based-policies/prioritized-traffic.mdx

Added Files

  • src/content/partials/magic-wan/connector/app-aware-policies/breakout-prioritized.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

…eakout-prioritized.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

1. Send a `GET` [request](/api/resources/magic_transit/subresources/apps/methods/list/) to list the applications associated with an account.

<APIRequest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We no longer show an example response.

method="GET"
/>

Take note of the `"account_app_id"` value for the application that want to delete.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd indent this line so it's part of step 1.

@marciocloudflare marciocloudflare enabled auto-merge (squash) March 12, 2025 09:58
@marciocloudflare marciocloudflare merged commit 6807473 into production Mar 12, 2025
11 checks passed
@marciocloudflare marciocloudflare deleted the marcio/pcx15975b-magic-api branch March 12, 2025 10:06
elithrar pushed a commit that referenced this pull request Mar 14, 2025
* added apirequest

* deleted old api

* updated response example

* added post request

* deteled unecessary step

* deleted old example

* added new response example

* removed extra space

* added delete apirequest

* deleted old example

* added response example

* update var name

* added delete apirequest

* deleted old api

* added response example

* deleted 1st old step

* added new apirequest

* changed name example

* added example

* added list apirequest

* deleted old api example

* added new response example

* corrected var name

* added new examples deleted old

* added test

* removed test

* created partial
added content

* added content

* corrected problems for breakout

* added render file prioritized

* changed note to h2

* moved the aside to breaktout only

* moved warp title to breakout

* removed markdown import

* removed old partials

* removed extra var

* removed extra var

* readded step 1 list apps

* added jsontype

* refined commands

* deleted message

* deleted list

* deleted example

* Update src/content/partials/magic-wan/connector/app-aware-policies/breakout-prioritized.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* indented line

* added json output

* added props.jsontype

* added json type

* changed type

* idented json

* added output

---------

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
* added apirequest

* deleted old api

* updated response example

* added post request

* deteled unecessary step

* deleted old example

* added new response example

* removed extra space

* added delete apirequest

* deleted old example

* added response example

* update var name

* added delete apirequest

* deleted old api

* added response example

* deleted 1st old step

* added new apirequest

* changed name example

* added example

* added list apirequest

* deleted old api example

* added new response example

* corrected var name

* added new examples deleted old

* added test

* removed test

* created partial
added content

* added content

* corrected problems for breakout

* added render file prioritized

* changed note to h2

* moved the aside to breaktout only

* moved warp title to breakout

* removed markdown import

* removed old partials

* removed extra var

* removed extra var

* readded step 1 list apps

* added jsontype

* refined commands

* deleted message

* deleted list

* deleted example

* Update src/content/partials/magic-wan/connector/app-aware-policies/breakout-prioritized.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* indented line

* added json output

* added props.jsontype

* added json type

* changed type

* idented json

* added output

---------

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants