-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Added experimental to workers-types package #20866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added experimental to workers-types package #20866
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryIntroduced experimental types in the workers-types package to enhance TypeScript support.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add What is Hyperlint?Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation. |
|
Hi @GregBrimble - Would you mind checking that this is the best approach to fix #13899 . I figured just making the experimental one the recommendation made sense because it links to more info anyway. Let me know if you think any more info is needed. Thank you! |
|
Preview URL: https://780ba2e8.preview.developers.cloudflare.com Files with changes (up to 15) |
GregBrimble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, no, I don't think we want this to be the recommendation. We'd rather people set their relevant date. experimental is just an alias for everything. Best left as-is, I think.
|
We now recommend generated types anyway. |
|
Closing per Greg's recommendations in comments |
Fixes #13899