-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Create Hono + Workers Assets doc, update Pages doc #20982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryCreated documentation for Hono framework integration with Cloudflare Workers and updated existing Pages documentation to align with recent changes.
Modified Files
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add What is Hyperlint?Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation. |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I just left a couple of minor comments 🙂
| ``` | ||
|
|
||
| Installing `npm-run-all` enables you to use a single command (`npm run dev`) to run `npm run dev:wrangler` and `npm run dev:esbuild` simultaneously in watch mode. | ||
| In your new Hono project, you will find a `public/static` directory for your static files, and a `src/index.ts` file which is the entrypoint for your server-side code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In your new Hono project, you will find a `public/static` directory for your static files, and a `src/index.ts` file which is the entrypoint for your server-side code. | |
| In your new Hono project, you will find a `public/static` directory for your static files, and an `src/index.ts` file which is the entrypoint for your server-side code. |
Co-authored-by: Dario Piotrowicz <[email protected]>
* update pages hono docs * create workers + hono doc * Update src/content/docs/workers/frameworks/framework-guides/hono.mdx Co-authored-by: Dario Piotrowicz <[email protected]> --------- Co-authored-by: Dario Piotrowicz <[email protected]>
Summary
Hono doesn't have a workers + assets doc, this just includes a first pass scaffold along the lines of all the other framework docs.
Also noticed the Pages + Hono doc didn't match up with what c3 was generating any more, so i've fixed up that template in c3 and updated those docs.