[Docs Site] Only show external link arrow if element has no image children #20998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
GregBrimble
reviewed
Mar 20, 2025
| import rehypeExternalLinks, { type Options } from "rehype-external-links"; | ||
| import type { Element } from "hast"; | ||
|
|
||
| function hasImgChild(node: Element): boolean { |
Contributor
There was a problem hiding this comment.
Hard to imagine ever intentionally linking over more than just a single image child, but I guess in those cases you also probably don't want ↗. Fair enough!
Member
Author
There was a problem hiding this comment.
I admittedly stole it from rehype-external-links themselves - they have it in their tests: https://github.com/rehypejs/rehype-external-links/blob/b0ada86b178e135d55368ffa47b915db17219716/test.js#L388-L398
GregBrimble
approved these changes
Mar 20, 2025
github-actions
bot
assigned
GregBrimble,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Contributor
|
Preview URL: https://206237b5.preview.developers.cloudflare.com |
kodster28
approved these changes
Mar 20, 2025
RebeccaTamachiro
pushed a commit
that referenced
this pull request
Apr 21, 2025
…ldren (#20998) * [Docs Site] Only show external link arrow if element has no image children * unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only show external link arrow if element has no image children