[Astro] Pcx_product should be name, not property #21021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodster28
requested review from
a team,
GregBrimble,
KianNH,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
KianNH,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Contributor
|
Preview URL: https://a90f67b7.preview.developers.cloudflare.com |
KianNH
approved these changes
Mar 21, 2025
RebeccaTamachiro
pushed a commit
that referenced
this pull request
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Borked a piece of our search indexing in #20936. Should flip back to old logic b/c it mirrors what the other values are called too.
Before (
<meta property="pcx_product"...>)After (
<meta name="pcx_product"...>)