add deploy to cloudflare docs + fix getting started #21107
Conversation
nevikashah
requested review from
a team,
GregBrimble,
ToriLindsay,
WalshyDev,
irvinebroque and
mikenomitch
as code owners
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated the getting started guide and added documentation for setting up a Deploy to Cloudflare button.
Modified Files
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
github-actions
bot
assigned
GregBrimble,
irvinebroque,
mikenomitch,
ToriLindsay and
WalshyDev
ToriLindsay
left a comment
ToriLindsay
left a comment
There was a problem hiding this comment.
@nevikashah
Assuming you're going to replace those insert screenshot notes with files, I'm approving. I reviewed this for grammar and added some other lighter suggestions, but I also have some ideas for re-structuring the Deploy to Cloudflare doc which I'll DM you about, but I wanted to unblock you in the meantime.
nevikashah
force-pushed
the
nevi/deploy-to-cloudflare-button
branch
from
4753cb0 to
70a2124
Compare
|
This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
|
irvinebroque
left a comment
irvinebroque
left a comment
There was a problem hiding this comment.
Curious why whole new top-level section?
irvinebroque
left a comment
irvinebroque
left a comment
There was a problem hiding this comment.
Makes sense – tricky to find spot for it in docs today but worth a pass at finding places that exist today where we think this should be discoverable
irvinebroque
left a comment
irvinebroque
left a comment
There was a problem hiding this comment.
Content makes sense but don't think having whole new top-level section called "community" with just one page does.
* add deploy to cloudflare docs + fix getting started * remove old d2w docs and add community section * Update src/content/docs/workers/community/deploy-buttons.mdx * Update src/content/docs/workers/community/deploy-buttons.mdx * Update src/content/docs/workers/community/deploy-buttons.mdx * updates based on feedback --------- Co-authored-by: Nevi <[email protected]> Co-authored-by: ToriLindsay <[email protected]> Co-authored-by: Daniel Walsh <[email protected]>
9 participants
Summary
Documentation checklist