-
Notifications
You must be signed in to change notification settings - Fork 10.2k
update wrangler config docs to include vite plugin #21137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated Vite plugin configuration documentation to include details on module aliasing.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
b7b4177 to
db991a8
Compare
c5f644a to
4717e35
Compare
0ae5386 to
669886f
Compare
jamesopstad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @emily-shen! Added a few comments but looks good.
src/content/partials/workers/workers-assets-routing-summary.mdx
Outdated
Show resolved
Hide resolved
src/content/partials/workers/workers-assets-routing-summary.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: James Opstad <[email protected]>
Co-authored-by: James Opstad <[email protected]>
* aliasing as example * note when not applicable to vite plugin * fixups * revert notice about upload_source_maps * shorten asset routing summary * some assets updates * update links and env notes * Apply suggestions from code review * update routing summary * Update src/content/docs/workers/static-assets/index.mdx Co-authored-by: James Opstad <[email protected]> * Apply suggestions from code review Co-authored-by: James Opstad <[email protected]> --------- Co-authored-by: James Opstad <[email protected]>
Summary
Screenshots (optional)
Documentation checklist