Skip to content

Conversation

@ToriLindsay
Copy link
Contributor

Fixes #18581

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 1, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated service binding documentation to require a valid URL for new requests.

  • Added a note about providing a valid URL with a hostname for new requests.
  • Included an example of creating a new request with a valid URL.

Modified Files

  • src/content/docs/workers/runtime-apis/bindings/service-bindings/http.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@ToriLindsay
Copy link
Contributor Author

@GregBrimble Would you mind checking this for accuracy and that it fixes #18581 ? I just took my best guess. Also, let me know if you think it needs more of an acknowledgement that (as I understand it) the URL is fairly arbitrary and will be ignored, but is needed anyway.

@GregBrimble
Copy link
Contributor

GregBrimble commented Apr 1, 2025

It's arbitrary, in the sense that a user can provide any URL at all. But it still matters as a legitimate value that the callee will receive and can act on if it chooses to.

@ToriLindsay ToriLindsay merged commit bc55240 into production Apr 14, 2025
11 checks passed
@ToriLindsay ToriLindsay deleted the tori/pcx-18581-service-binding-url-requirement branch April 14, 2025 16:01
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
* Service binding URL requirement

* Update src/content/docs/workers/runtime-apis/bindings/service-bindings/http.mdx

Co-authored-by: Greg Brimble <[email protected]>

* Update src/content/docs/workers/runtime-apis/bindings/service-bindings/http.mdx

---------

Co-authored-by: Greg Brimble <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify HTTP Service Binding Needs Valid URL

5 participants