-
Notifications
You must be signed in to change notification settings - Fork 10k
[Workers] Service binding URL requirement #21288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workers] Service binding URL requirement #21288
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated service binding documentation to require a valid URL for new requests.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
@GregBrimble Would you mind checking this for accuracy and that it fixes #18581 ? I just took my best guess. Also, let me know if you think it needs more of an acknowledgement that (as I understand it) the URL is fairly arbitrary and will be ignored, but is needed anyway. |
|
Preview URL: https://c5f5dd1b.preview.developers.cloudflare.com Files with changes (up to 15) |
src/content/docs/workers/runtime-apis/bindings/service-bindings/http.mdx
Outdated
Show resolved
Hide resolved
|
It's arbitrary, in the sense that a user can provide any URL at all. But it still matters as a legitimate value that the callee will receive and can act on if it chooses to. |
…s/http.mdx Co-authored-by: Greg Brimble <[email protected]>
src/content/docs/workers/runtime-apis/bindings/service-bindings/http.mdx
Outdated
Show resolved
Hide resolved
* Service binding URL requirement * Update src/content/docs/workers/runtime-apis/bindings/service-bindings/http.mdx Co-authored-by: Greg Brimble <[email protected]> * Update src/content/docs/workers/runtime-apis/bindings/service-bindings/http.mdx --------- Co-authored-by: Greg Brimble <[email protected]>
Fixes #18581