-
Notifications
You must be signed in to change notification settings - Fork 10k
[SaaS] Review scenarios for hostname priority #21893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RebeccaTamachiro
merged 9 commits into
production
from
rebecca/cf4saas-hostname-priority
Apr 24, 2025
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3a229cc
Add GlossaryTooltip for proxied and zone terminology
RebeccaTamachiro 29b4ca1
Remove second possibility and call out 1014 error
RebeccaTamachiro db78b37
Update second bullet to mention Orange-to-Orange
RebeccaTamachiro 7415139
Disambiguate: Customer1 zone is not a SaaS provider
RebeccaTamachiro 4b5a96b
Edit to refer back to what had been explained in the intro
RebeccaTamachiro b63e191
Further disambiguate Customer1 is not a SaaS provider
RebeccaTamachiro 8ea395f
Apply suggestion from PM review: clarify example refers to new CH
RebeccaTamachiro 760a9f2
Apply suggestion from code review
RebeccaTamachiro 1c75df3
Apply suggestion from CSUP: further clarify legacy SaaS provider
RebeccaTamachiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.