Skip to content

Conversation

@harshil1712
Copy link
Contributor

Summary

Update the types and also added note for Service Workers code snippet.

Documentation checklist

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 5, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated types and added a caution note regarding the deprecation of Service Workers in the email routing documentation.

  • Updated the type from EmailMessage to ForwardableEmailMessage.
  • Added a caution note indicating that Service Workers are deprecated but still supported.
  • Provided an example of handling EmailEvent using Service Worker syntax.

Modified Files

  • src/content/docs/email-routing/email-workers/runtime-api.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@harshil1712 harshil1712 changed the title update types and add note for service worker [Email Worker] Update type May 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

@harshil1712 harshil1712 merged commit 67cbc8b into production May 7, 2025
12 checks passed
@harshil1712 harshil1712 deleted the email-worker-type-fix branch May 7, 2025 07:45
daisyfaithauma pushed a commit that referenced this pull request May 7, 2025
* update types and add note for service worker

* Update src/content/docs/email-routing/email-workers/runtime-api.mdx

* Retrigger CI

---------

Co-authored-by: ToriLindsay <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
daisyfaithauma pushed a commit that referenced this pull request May 8, 2025
* update types and add note for service worker

* Update src/content/docs/email-routing/email-workers/runtime-api.mdx

* Retrigger CI

---------

Co-authored-by: ToriLindsay <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
Maddy-Cloudflare pushed a commit that referenced this pull request May 9, 2025
* update types and add note for service worker

* Update src/content/docs/email-routing/email-workers/runtime-api.mdx

* Retrigger CI

---------

Co-authored-by: ToriLindsay <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
daisyfaithauma pushed a commit that referenced this pull request May 13, 2025
* update types and add note for service worker

* Update src/content/docs/email-routing/email-workers/runtime-api.mdx

* Retrigger CI

---------

Co-authored-by: ToriLindsay <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants