Skip to content

Conversation

@lrapoport-cf
Copy link
Contributor

Summary

Update to some of the assets documentation. Specifically, this updates the assets routing behavior section to outline behavior for all of the not_found_handling options, and then changes the links in other pages for not_found_handling to point to the updated section.

Also includes some small typos found in various places.

Documentation checklist

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 8, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated assets documentation to clarify routing behavior and fixed typos throughout the documentation.

  • Enhanced the assets routing behavior section to detail all not_found_handling options.
  • Updated links in various pages to point to the revised routing behavior section.
  • Corrected minor typos in multiple documentation files.

Modified Files

  • src/content/docs/workers/configuration/multipart-upload-metadata.mdx
  • src/content/docs/workers/frameworks/framework-guides/react.mdx
  • src/content/docs/workers/static-assets/binding.mdx
  • src/content/docs/workers/static-assets/index.mdx
  • src/content/docs/workers/static-assets/routing/advanced/html-handling.mdx
  • src/content/docs/workers/static-assets/routing/static-site-generation.mdx
  • src/content/docs/workers/wrangler/configuration.mdx
  • src/content/partials/workers/workers-assets-routing-summary.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Preview URL: https://f5ebf920.preview.developers.cloudflare.com
Preview Branch URL: https://lrapoport-fixes-and-updates.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/configuration/multipart-upload-metadata/ https://lrapoport-fixes-and-updates.preview.developers.cloudflare.com/workers/configuration/multipart-upload-metadata/
https://developers.cloudflare.com/workers/static-assets/ https://lrapoport-fixes-and-updates.preview.developers.cloudflare.com/workers/static-assets/
https://developers.cloudflare.com/workers/wrangler/configuration/ https://lrapoport-fixes-and-updates.preview.developers.cloudflare.com/workers/wrangler/configuration/
https://developers.cloudflare.com/workers/static-assets/binding/ https://lrapoport-fixes-and-updates.preview.developers.cloudflare.com/workers/static-assets/binding/
https://developers.cloudflare.com/workers/static-assets/routing/static-site-generation/ https://lrapoport-fixes-and-updates.preview.developers.cloudflare.com/workers/static-assets/routing/static-site-generation/
https://developers.cloudflare.com/workers/frameworks/framework-guides/react/ https://lrapoport-fixes-and-updates.preview.developers.cloudflare.com/workers/frameworks/framework-guides/react/
https://developers.cloudflare.com/workers/static-assets/routing/advanced/html-handling/ https://lrapoport-fixes-and-updates.preview.developers.cloudflare.com/workers/static-assets/routing/advanced/html-handling/

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

Copy link
Contributor

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of suggestions.

@lrapoport-cf lrapoport-cf merged commit cd84b00 into production May 8, 2025
12 checks passed
@lrapoport-cf lrapoport-cf deleted the lrapoport/fixes-and-updates branch May 8, 2025 19:09
Maddy-Cloudflare pushed a commit that referenced this pull request May 9, 2025
* Fix typos

* Update links for routing behavior and not_found_handling.

* Update routing behavior section

---------

Co-authored-by: Greg Brimble <[email protected]>
daisyfaithauma pushed a commit that referenced this pull request May 13, 2025
* Fix typos

* Update links for routing behavior and not_found_handling.

* Update routing behavior section

---------

Co-authored-by: Greg Brimble <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants