-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Assets updates (and typo fixes) #22287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated assets documentation to clarify routing behavior and fixed typos throughout the documentation.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit
GregBrimble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a couple of suggestions.
Co-authored-by: Greg Brimble <[email protected]>
Co-authored-by: Greg Brimble <[email protected]>
* Fix typos * Update links for routing behavior and not_found_handling. * Update routing behavior section --------- Co-authored-by: Greg Brimble <[email protected]>
* Fix typos * Update links for routing behavior and not_found_handling. * Update routing behavior section --------- Co-authored-by: Greg Brimble <[email protected]>
Summary
Update to some of the assets documentation. Specifically, this updates the assets routing behavior section to outline behavior for all of the
not_found_handlingoptions, and then changes the links in other pages for not_found_handling to point to the updated section.Also includes some small typos found in various places.
Documentation checklist