Skip to content

Conversation

@ketanhwr
Copy link
Member

@ketanhwr ketanhwr commented May 8, 2025

Revert #22239 now that these changes have been released to prod.

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 8, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Reverted changes from pull request #22239 and added documentation for the FinalizationRegistry feature in Workers.

  • Added documentation for the FinalizationRegistry feature in Workers.
  • Introduced compatibility flag for enabling FinalizationRegistry and WeakRef.
  • Provided details on memory efficiency improvements for WebAssembly Workers.

Added Files

  • src/content/changelog/workers/2025-05-08-finalization-registry.mdx
  • src/content/compatibility-flags/js-weak-refs.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@nikitacano nikitacano merged commit f2ae74b into cloudflare:production May 8, 2025
6 checks passed
Maddy-Cloudflare pushed a commit that referenced this pull request May 9, 2025
* Add compat flag docs for FinalizationRegistry and WeakRef

* Add changelog entry for FinalizationRegistry

* Address review comments

* Address review comments
daisyfaithauma pushed a commit that referenced this pull request May 13, 2025
* Add compat flag docs for FinalizationRegistry and WeakRef

* Add changelog entry for FinalizationRegistry

* Address review comments

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants