Skip to content

Conversation

@kennyj42
Copy link
Contributor

Our account team found this issue in a customer POC. You need to ensure you're also sending a certificate as part of the SAML response

Summary

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Our account team found this issue in a customer POC. You need to ensure you're also sending a <keyinfo> certificate as part of the SAML response
@kennyj42 kennyj42 requested review from a team and ranbel as code owners May 15, 2025 19:53
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 15, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated the SAML integration documentation for PingFederate to include the requirement for a certificate in the SAML response.

  • Added instructions to include a matching certificate in the SAML response
  • Updated step numbers for clarity
  • Clarified settings for Signature Policy in PingFederate

Modified Files

  • src/content/docs/cloudflare-one/identity/idp-integration/pingfederate-saml.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/cloudflare-one/identity/ @kennyj42, @ranbel, @cloudflare/pcx-technical-writing

@jroyal
Copy link
Contributor

jroyal commented May 15, 2025

lgtm

@ranbel ranbel enabled auto-merge (squash) May 15, 2025 20:33
@ranbel ranbel merged commit c8b5a53 into production May 15, 2025
11 checks passed
@ranbel ranbel deleted the kennyj42-patch-6 branch May 15, 2025 20:34
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
* Update pingfederate-saml.mdx

Our account team found this issue in a customer POC. You need to ensure you're also sending a <keyinfo> certificate as part of the SAML response

* Apply suggestions from code review

* Update src/content/docs/cloudflare-one/identity/idp-integration/pingfederate-saml.mdx

---------

Co-authored-by: ranbel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants