Skip to content

[DO] Recommending restricting DurableObjectNamespace to jurisdiction, rather than DurableObjectID #22494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2025
Merged

[DO] Recommending restricting DurableObjectNamespace to jurisdiction, rather than DurableObjectID #22494

merged 6 commits into from
May 30, 2025

Conversation

@Oxyjun
Copy link
Contributor

@Oxyjun Oxyjun commented May 16, 2025

Summary

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions github-actions bot added the product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ label May 16, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 16, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Updated documentation to recommend restricting DurableObjectNamespace to jurisdiction instead of DurableObjectID.

  • Clarified that Durable Objects should be restricted to a jurisdiction using DurableObjectNamespace.
  • Removed the recommendation for using DurableObjectID with jurisdiction.
  • Updated code examples to reflect the new recommendation.

Modified Files

  • src/content/docs/durable-objects/reference/data-location.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/durable-objects/ @elithrar, @vy-ton, @joshthoward, @oxyjun, @harshil1712, @cloudflare/pcx-technical-writing

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2025 •
edited
Loading

Preview URL: https://3fad9623.preview.developers.cloudflare.com
Preview Branch URL: https://jun-do-jurisdiction-recommendation.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/durable-objects/reference/data-location/ https://jun-do-jurisdiction-recommendation.preview.developers.cloudflare.com/durable-objects/reference/data-location/

vy-ton
vy-ton reviewed May 19, 2025
View reviewed changes
vy-ton
vy-ton reviewed May 28, 2025
View reviewed changes
@vy-ton
Copy link
Contributor

vy-ton commented May 30, 2025

image

The code at the bottom applies to the first bullet

@Oxyjun Oxyjun merged commit e99e23b into production May 30, 2025
11 checks passed
@Oxyjun Oxyjun deleted the jun/do/jurisdiction-recommendation branch May 30, 2025 16:32
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
@Oxyjun @sdnts
[DO] Recommending restricting DurableObjectNamespace to jurisdiction,…
91ad4d9 
… rather than DurableObjectID (cloudflare#22494)

* Not recommending newUniqueId(jurisdiction) approach

* Iterating over the docs for clarity and better
information segregation

* Iterating on feedback

* Turning code blocks into in-line code, restructure

* Cleaning up footnote lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vy-ton vy-ton vy-ton approved these changes

@deadlypants1973 deadlypants1973 deadlypants1973 approved these changes

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@joshthoward joshthoward Awaiting requested review from joshthoward joshthoward is a code owner

@harshil1712 harshil1712 Awaiting requested review from harshil1712 harshil1712 is a code owner

Assignees

@elithrar elithrar

@joshthoward joshthoward

@vy-ton vy-ton

@harshil1712 harshil1712

@Oxyjun Oxyjun

Labels

product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Oxyjun @vy-ton @deadlypants1973 @elithrar @joshthoward @harshil1712