Skip to content

[Docs Site] Remove Container API usage from changelog #22591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

[Docs Site] Remove Container API usage from changelog #22591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
265fbb3
[Docs Site] Remove Container API usage from changelog
KianNH May 21, 2025
75f7f43
dont use style prop
KianNH May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions astro.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import rehypeMermaid from "./src/plugins/rehype/mermaid.ts";
import rehypeAutolinkHeadings from "./src/plugins/rehype/autolink-headings.ts";
import rehypeExternalLinks from "./src/plugins/rehype/external-links.ts";
import rehypeHeadingSlugs from "./src/plugins/rehype/heading-slugs.ts";
import rehypeShiftHeadings from "./src/plugins/rehype/shift-headings.ts";

async function autogenSections() {
const sections = (
Expand Down Expand Up @@ -67,6 +68,7 @@ export default defineConfig({
rehypeAutolinkHeadings,
// @ts-expect-error plugins types are outdated but functional
rehypeTitleFigure,
rehypeShiftHeadings,
],
},
image: {
Expand Down
31 changes: 14 additions & 17 deletions src/pages/changelog/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ import { Steps } from "~/components";
import { format } from "date-fns";
import { getChangelogs } from "~/util/changelog";
import { productsByGroup } from "~/util/products";
import { entryToString } from "~/util/container";
import { process } from "~/util/rehype";

import rehypeShiftHeadings from "~/plugins/rehype/shift-headings.ts";
import { render } from "astro:content";

const notes = await getChangelogs({
filter: (entry) => !entry.data.hidden,
Expand Down Expand Up @@ -45,24 +43,22 @@ const props = {
.map((group) => group[0])
.sort();

const html = await entryToString(entry, Astro.locals);
const processed = await process(html, [[rehypeShiftHeadings]]);
const { Content } = await render(entry);

return (
<div
class="mt-0! sm:flex"
class:list={["mt-0! sm:flex", { "hidden!": idx >= 10 }]}
data-products={JSON.stringify(
productIds.concat(
productGroups.map((group) =>
group.replaceAll(" ", "-").toLowerCase(),
),
),
)}
style={`display: ${idx >= 10 ? "none" : ""}`}
>
<time
datetime={entry.data.date.toISOString()}
class="whitespace-nowrap text-xs font-bold leading-6 sm:pr-4 sm:text-right"
class="text-xs leading-6 font-bold whitespace-nowrap sm:pr-4 sm:text-right"
>
{date}
</time>
Expand All @@ -80,7 +76,7 @@ const props = {
</h3>
<ProductPills products={entry.data.products} />
</div>
<p set:html={processed} />
<Content />
</li>
</ol>
</Steps>
Expand All @@ -91,7 +87,7 @@ const props = {
<div class="flex items-center justify-center">
<button
id="changelogs-next-button"
class="h-12 cursor-pointer rounded-sm bg-cl1-brand-orange px-6 font-medium text-cl1-black"
class="bg-cl1-brand-orange text-cl1-black h-12 cursor-pointer rounded-sm px-6 font-medium"
>
Load more items
</button>
Expand Down Expand Up @@ -134,11 +130,12 @@ const props = {
...document.querySelectorAll<HTMLElement>("[data-products]"),
]
.filter(
(e) => e.style.display === "none" && filterByProduct(e, filter!.value),
(e) =>
e.classList.contains("hidden!") && filterByProduct(e, filter!.value),
)
.slice(0, 10);

hidden.forEach((e) => (e.style.display = ""));
hidden.forEach((e) => e.classList.remove("hidden!"));

hideButton();
});
Expand All @@ -160,9 +157,9 @@ const props = {
const show = filtered.includes(entry);

if (show) {
entry.style.display = "";
entry.classList.remove("hidden!");
} else {
entry.style.display = "none";
entry.classList.add("hidden!");
}
}

Expand All @@ -188,13 +185,13 @@ const props = {

const filtered = entries.filter((p) => filterByProduct(p, filter!.value));

const visible = filtered.filter((p) => p.style.display !== "none");
const visible = filtered.filter((p) => !p.classList.contains("hidden!"));
const hidden = filtered.length - visible.length;

if (hidden > 0) {
button!.style.display = "";
button!.classList.remove("hidden!");
} else {
button!.style.display = "none";
button!.classList.add("hidden!");
}
}
</script>
Expand Down
10 changes: 9 additions & 1 deletion src/plugins/rehype/shift-headings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,16 @@ import { visit } from "unist-util-visit";
import type { Root, Element } from "hast";

export default function () {
return function (tree: Root) {
return function (tree: Root, file: any) {
visit(tree, "element", function (element) {
if (
!file.history.find((path: string) =>
path.includes("/src/content/changelog/"),
)
) {
return;
}

const classNames = (element.properties.className as string[]) ?? [];

if (classNames.includes("heading-wrapper")) {
Expand Down
Loading