-
Notifications
You must be signed in to change notification settings - Fork 10k
Fix Durable Objects TTL example where long TTLs lead to infinite alar… #22728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated the Durable Objects TTL example to clarify the correct implementation of Time To Live (TTL) and prevent infinite alarm invocations.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://36fb1fc0.preview.developers.cloudflare.com Files with changes (up to 15) |
|
|
||
| A common feature request for Durable Objects is a Time To Live (TTL) for Durable Object instances. Durable Objects give developers the tools to implement a custom TTL in only a few lines of code. This example demonstrates how to implement a TTL making use of <GlossaryTooltip term="alarm">`alarms`</GlossaryTooltip>. While this TTL will be extended upon every new request to the Durable Object, this can be customized based on a particular use case. | ||
|
|
||
| :::caution[Not available in local development] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the title say not available in local dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think alarm support in local dev is limited/non-existent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a copy/paste error. Thank you for catching @vy-ton.
|
@Oxyjun as a separate task, can we also enhance the alarm docs with:
|
Tracking this here: #22746 |
src/content/docs/durable-objects/examples/durable-object-ttl.mdx
Outdated
Show resolved
Hide resolved
|
This PR is replaced by #22761 because of the new security rules for our GitHub account. |
…m invocations
Summary
Screenshots (optional)
Documentation checklist