Skip to content

Conversation

@deadlypants1973
Copy link
Contributor

Summary

PCX-17432

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@deadlypants1973 deadlypants1973 requested a review from a team as a code owner May 30, 2025 15:11
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/cloudflare-one/identity/ @kennyj42, @ranbel, @cloudflare/pcx-technical-writing
* @cloudflare/pcx-technical-writing

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 30, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Enhanced documentation for device posture checks by including details on serial numbers and their importance in identifying devices accurately.

  • Added information on the significance of unique serial numbers for device identification in posture checks.
  • Updated the integration documentation for SentinelOne to emphasize the need for unique serial numbers.
  • Clarified the requirements for external API integrations regarding device identification.

Modified Files

  • src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx
  • src/content/docs/cloudflare-one/identity/devices/service-providers/sentinelone.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

import { Markdown } from "~/components";

Cloudflare Zero Trust can integrate with {props.one} to require that users connect to certain applications from managed devices. This service-to-service posture check uses the WARP client to read endpoint data from {props.one}. Devices are identified by their serial numbers.
Cloudflare Zero Trust can integrate with {props.one} to require that users connect to certain applications from managed devices. This service-to-service posture check uses the WARP client to read endpoint data from {props.one}. Devices are identified by their serial numbers. If multiple devices have the same serial number, we cannot accurately match a Cloudflare device with a third-party provider device. You must ensure that each of your devices has a unique serial number.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Justin Lu to review

Copy link

@jlu-cloudflare jlu-cloudflare Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement is accurate, but maybe it could be changed to 3rd person to match the rest of the docs. Something like:
"If multiple devices have the same serial number, it is not possible to accurately match a Cloudflare device with a third-party provider device. It is essential to ensure that each device has a unique serial number."


:::note

Devices are identified by their serial numbers. You must ensure that each of your devices has a unique serial number. If multiple devices have the same serial number, Cloudflare and your external API will not be able to accurately match them.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Justin Lu to review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change it to third person to match the rest of the docs. possibly:
"Devices are identified by their serial numbers. It is essential to ensure that each device has a unique serial number. If multiple devices have the same serial number, it is not possible to accurately match a Cloudflare device with a third-party provider device."

PCX suggestion

Co-authored-by: Jun Lee <[email protected]>
@deadlypants1973 deadlypants1973 merged commit 3b46316 into production Jun 4, 2025
11 checks passed
@deadlypants1973 deadlypants1973 deleted the kate/fixes-serialnumbers branch June 4, 2025 16:28
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
* [CF1] add details on serial numbers in posture checks

* edits

* sentinelone edit

* Update src/content/partials/cloudflare-one/posture/service-provider-intro.mdx

Ranbel edit

* Apply suggestions from code review

PCX suggestion

Co-authored-by: Jun Lee <[email protected]>

---------

Co-authored-by: Jun Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants