-
Notifications
You must be signed in to change notification settings - Fork 10k
[CF1] add details on serial numbers in posture checks #22790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryEnhanced documentation for device posture checks by including details on serial numbers and their importance in identifying devices accurately.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
| import { Markdown } from "~/components"; | ||
|
|
||
| Cloudflare Zero Trust can integrate with {props.one} to require that users connect to certain applications from managed devices. This service-to-service posture check uses the WARP client to read endpoint data from {props.one}. Devices are identified by their serial numbers. | ||
| Cloudflare Zero Trust can integrate with {props.one} to require that users connect to certain applications from managed devices. This service-to-service posture check uses the WARP client to read endpoint data from {props.one}. Devices are identified by their serial numbers. If multiple devices have the same serial number, we cannot accurately match a Cloudflare device with a third-party provider device. You must ensure that each of your devices has a unique serial number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Justin Lu to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The statement is accurate, but maybe it could be changed to 3rd person to match the rest of the docs. Something like:
"If multiple devices have the same serial number, it is not possible to accurately match a Cloudflare device with a third-party provider device. It is essential to ensure that each device has a unique serial number."
|
|
||
| :::note | ||
|
|
||
| Devices are identified by their serial numbers. You must ensure that each of your devices has a unique serial number. If multiple devices have the same serial number, Cloudflare and your external API will not be able to accurately match them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Justin Lu to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps change it to third person to match the rest of the docs. possibly:
"Devices are identified by their serial numbers. It is essential to ensure that each device has a unique serial number. If multiple devices have the same serial number, it is not possible to accurately match a Cloudflare device with a third-party provider device."
src/content/partials/cloudflare-one/posture/service-provider-intro.mdx
Outdated
Show resolved
Hide resolved
…ntro.mdx Ranbel edit
src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx
Outdated
Show resolved
Hide resolved
PCX suggestion Co-authored-by: Jun Lee <[email protected]>
* [CF1] add details on serial numbers in posture checks * edits * sentinelone edit * Update src/content/partials/cloudflare-one/posture/service-provider-intro.mdx Ranbel edit * Apply suggestions from code review PCX suggestion Co-authored-by: Jun Lee <[email protected]> --------- Co-authored-by: Jun Lee <[email protected]>
Summary
PCX-17432
Screenshots (optional)
Documentation checklist