-
Notifications
You must be signed in to change notification settings - Fork 10k
[Docs Site] Enforce and transform frontmatter tags #22836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e10d704
[Docs Site] Enforce and transform frontmatter tags
KianNH cdb4a91
Merge branch 'production' into kian/PCX-16226
kodster28 cf452dd
remove KV tags
kodster28 bdf5b31
other content updates
kodster28 b6c21e1
update tags docs and error
KianNH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
src/content/docs/kv/examples/implement-ab-testing-with-workers-kv.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,9 @@ | ||
| --- | ||
| type: example | ||
| summary: Use Workers KV to store A/B testing configuration data and analyze the performance of different versions of your website | ||
| tags: | ||
| - KV | ||
| pcx_content_type: configuration | ||
| title: A/B testing with Workers KV | ||
| external_link: /reference-architecture/diagrams/serverless/a-b-testing-using-workers/ | ||
| sidebar: | ||
| order: 6 | ||
| --- | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { defineRouteMiddleware } from "@astrojs/starlight/route-data"; | ||
| import { tags as allowedTags } from "~/schemas/tags"; | ||
|
|
||
| export const onRequest = defineRouteMiddleware(({ locals }) => { | ||
| const { entry } = locals.starlightRoute; | ||
| const { tags } = entry.data; | ||
|
|
||
| if (tags) { | ||
| const transformed = tags.map((tag) => { | ||
| const values = Object.values(allowedTags).flat(); | ||
|
|
||
| const match = values.find( | ||
| (val) => | ||
| val.label.toLowerCase() === tag.toLowerCase() || | ||
| val.variants?.find((v) => v.toLowerCase() === tag.toLowerCase()), | ||
| ); | ||
|
|
||
| if (!match) { | ||
| throw new Error( | ||
| `Invalid tag on ${entry.id}: ${tag}, please refer to the allowlist in /src/schemas/tags.ts`, | ||
| ); | ||
| } | ||
|
|
||
| return match.label; | ||
| }); | ||
|
|
||
| entry.data.tags = transformed; | ||
| } | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an additional check for empty tag arrays to avoid unnecessary processing: