Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/label-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ concurrency:
jobs:
label_products:
name: Label products
permissions:
issues: write
pull-requests: write
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these permission blocks might cause the workflow to fail. GitHub Actions uses least-privilege permissions by default, and without explicit issues: write and pull-requests: write permissions, the labeling actions may not have sufficient access to modify labels on PRs.

If this is intentional (perhaps as part of a security review), please ensure the workflow still functions correctly after this change.

steps:
- uses: actions/checkout@v4
Expand All @@ -26,9 +23,6 @@ jobs:

label_size:
name: Label size
permissions:
issues: write
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ jobs:
compile:
name: Update assignees
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the permissions block may break the PR assignment functionality. The workflow uses an action that likely requires issues: write and pull-requests: write permissions to modify PR assignees. Without these explicit permissions, the action might fail with permission errors.

- uses: actions/checkout@v4
- uses: ./.github/actions/assign-pr
Expand Down