Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Jul 8, 2025

Summary

Clarify pattern matching for run_worker_first:

  • negative patterns have precedence over non-negative patterns
  • the order of the patterns is not significant

Also changed from "exception patterns" to "negative patterns" to align with the API docs:

Contains a list path rules to control routing to either the Worker or assets. Glob (*) and negative (!) rules are supported. Rules must start with either '/' or '!/'. At least one non-negative rule must be provided, and negative rules have higher precedence than non-negative rules.

Documentation checklist

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Jul 8, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Clarified pattern matching rules for the run_worker_first configuration in the documentation.

  • Updated terminology from 'exception patterns' to 'negative patterns' for consistency with API documentation.
  • Specified that negative patterns take precedence over non-negative patterns.
  • Clarified that the order of patterns is not significant.

Modified Files

  • src/content/docs/workers/static-assets/binding.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/workers/static-assets @irvinebroque, @GregBrimble, @WalshyDev, @kodster28, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

@vicb vicb merged commit 1a615f2 into production Jul 8, 2025
11 checks passed
@vicb vicb deleted the vicb/run-worker-first branch July 8, 2025 14:55
@vicb
Copy link
Contributor Author

vicb commented Jul 8, 2025

Thanks for the feedback Greg, I have integrated your suggestions.

sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
thomasgauvin pushed a commit that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants