Improve and extend node:http docs #23808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the `Agent` part of the docs to the end since it's only a stub impl and really isn't all that useful. Also improve the example to show how one might actually use it.
jasnell
requested review from
a team,
GregBrimble,
WalshyDev,
irvinebroque,
kodster28,
korinne and
mikenomitch
as code owners
jasnell
changed the title
irvinebroque
approved these changes
Jul 18, 2025
mikenomitch
approved these changes
Jul 20, 2025
| [`fetch` API](https://developers.cloudflare.com/workers/runtime-apis/fetch/) | ||
| and is therefore subject to the same [limits](https://developers.cloudflare.com/workers/platform/limits/). | ||
|
|
||
| As shown in the example above, it is necessary to arrange for requests to be correctly |
Contributor
There was a problem hiding this comment.
I think its probably worth calling out "Script will never generate a response" here by name and linking to that section.
If I'm reading this right, this is to get out ahead of people (like me) who didn't set up the callbacks properly and hit that. I think dropping the name here might help with SEO for this section and being able to debug that issue if it comes up w this.
thomasgauvin
pushed a commit
that referenced
this pull request
Aug 15, 2025
* Improve Agent example, move to end Move the `Agent` part of the docs to the end since it's only a stub impl and really isn't all that useful. Also improve the example to show how one might actually use it. * Improve and expand node:http docs, examples
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand and improve the
node:httpdocs.Screenshots (optional)
Documentation checklist