Remove dangling needs: test from Workers External CI/CD GitHub Actions example (#23994) #23995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programmer-RD-AI
requested review from
a team,
GregBrimble,
aninibread,
irvinebroque and
kodster28
as code owners
kodster28
approved these changes
Aug 5, 2025
Collaborator
kodster28
left a comment
kodster28
left a comment
There was a problem hiding this comment.
Thanks for the find / fix, @Programmer-RD-AI
workers-devprod
added
the
contribution
|
Congratulations @Programmer-RD-AI, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmdyvsz9k943307le9a2hhpa6 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
thomasgauvin
pushed a commit
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the extraneous
needs: testline from the “Build & Deploy Worker” snippet in the Workers CI/CD → External CI/CD (GitHub Actions) documentation. The current example references a non‑existenttestjob, causing the workflow to fail when copy‑pasted.closes #23994.